Commit aeb27bb7 authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Jason Gunthorpe
Browse files

RDMA/cxgb4: Fix missing error code in create_qp() 

The error code is missing in this code scenario so 0 will be returned. Add
the error code '-EINVAL' to the return value 'ret'.

Eliminates the follow smatch warning:

drivers/infiniband/hw/cxgb4/qp.c:298 create_qp() warn: missing error code 'ret'.

Link: https://lore.kernel.org/r/1622545669-20625-1-git-send-email-jiapeng.chong@linux.alibaba.com


Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent ef2a75c5

drivers/infiniband/hw/cxgb4/qp.c

+1 −0
Original line number Diff line number Diff line
@@ -295,6 +295,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq, 
	if (user && (!wq->sq.bar2_pa || (need_rq && !wq->rq.bar2_pa))) {

		pr_warn("%s: sqid %u or rqid %u not in BAR2 range\n",

			pci_name(rdev->lldi.pdev), wq->sq.qid, wq->rq.qid);

		ret = -EINVAL;

		goto free_dma;

	}