Commit 38b16d6c authored Jan 26, 2022 by 蒋家盛 Committed by Rafael J. Wysocki Feb 04, 2022

thermal: int340x: Check for NULL after calling kmemdup()



As the potential failure of the allocation, kmemdup() may return NULL.

Then, 'bin_attr_data_vault.private' will be NULL, but
'bin_attr_data_vault.size' is not 0, which is not consistent.

Therefore, it is better to check the return value of kmemdup() to
avoid the confusion.

Fixes: 0ba13c76 ("thermal/int340x_thermal: Export GDDV")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 26291c54

drivers/thermal/intel/int340x_thermal/int3400_thermal.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -464,6 +464,11 @@ static void int3400_setup_gddv(struct int3400_thermal_priv *priv)
		priv->data_vault = kmemdup(obj->package.elements[0].buffer.pointer,
		obj->package.elements[0].buffer.length,
		GFP_KERNEL);
		if (!priv->data_vault) {
		kfree(buffer.pointer);
		return;
		}

		bin_attr_data_vault.private = priv->data_vault;
		bin_attr_data_vault.size = obj->package.elements[0].buffer.length;
		kfree(buffer.pointer);