Commit 385c3e4c authored by Paul Hsieh's avatar Paul Hsieh Committed by Alex Deucher
Browse files

drm/amd/display: Correct DML calculation to follow HW SPEC 



[Why]
In 2560x1600@240p eDP panel, driver use lowest voltage level
to play 1080p video cause underflow. According to HW SPEC,
the senario should use high voltage level.

[How]
ChromaPre value is zero when bandwidth validation.
Correct ChromaPre calculation.

Reviewed-by: default avatarNicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Reviewed-by: default avatarJun Lei <Jun.Lei@amd.com>
Acked-by: default avatarQingqing Zhuo <qingqing.zhuo@amd.com>
Signed-off-by: default avatarPaul Hsieh <Paul.Hsieh@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 6f6869dc

drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c

+1 −1
Original line number Diff line number Diff line
@@ -4864,7 +4864,7 @@ void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l 
							v->DETBufferSizeCThisState[k],

							&v->UrgentBurstFactorCursorPre[k],

							&v->UrgentBurstFactorLumaPre[k],

							&v->UrgentBurstFactorChroma[k],

							&v->UrgentBurstFactorChromaPre[k],

							&v->NoUrgentLatencyHidingPre[k]);

				}

drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c

+1 −1
Original line number Diff line number Diff line
@@ -5191,7 +5191,7 @@ void dml31_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l 
							v->DETBufferSizeCThisState[k],

							&v->UrgentBurstFactorCursorPre[k],

							&v->UrgentBurstFactorLumaPre[k],

							&v->UrgentBurstFactorChroma[k],

							&v->UrgentBurstFactorChromaPre[k],

							&v->NotUrgentLatencyHidingPre[k]);

				}

drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c

+1 −1
Original line number Diff line number Diff line
@@ -5288,7 +5288,7 @@ void dml314_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_ 
							v->DETBufferSizeCThisState[k],

							&v->UrgentBurstFactorCursorPre[k],

							&v->UrgentBurstFactorLumaPre[k],

							&v->UrgentBurstFactorChroma[k],

							&v->UrgentBurstFactorChromaPre[k],

							&v->NotUrgentLatencyHidingPre[k]);

				}

drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c

+1 −1
Original line number Diff line number Diff line
@@ -3354,7 +3354,7 @@ void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l 
							/* Output */

							&mode_lib->vba.UrgentBurstFactorCursorPre[k],

							&mode_lib->vba.UrgentBurstFactorLumaPre[k],

							&mode_lib->vba.UrgentBurstFactorChroma[k],

							&mode_lib->vba.UrgentBurstFactorChromaPre[k],

							&mode_lib->vba.NotUrgentLatencyHidingPre[k]);

				}