Commit 385bf5a8 authored by Khalid Masum's avatar Khalid Masum Committed by Alex Deucher
Browse files

drm/amdgpu/vcn: Return void from the stop_dbg_mode 



There is no point in returning an int here. It only returns 0 which
the caller never uses. Therefore return void and remove the unnecessary
assignment.

Addresses-Coverity: 1504988 ("Unused value")
Fixes: 8da1170a ("drm/amdgpu: add VCN4 ip block support")
Reviewed-by: default avatarRuijing Dong <ruijing.dong@amd.com>
Suggested-by: default avatarRuijing Dong <ruijing.dong@amd.com>
Suggested-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKhalid Masum <khalid.masum.92@gmail.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent bf7f7efb

drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c

+2 −3
Original line number Diff line number Diff line
@@ -1115,7 +1115,7 @@ static int vcn_v4_0_start(struct amdgpu_device *adev) 
 *

 * Stop VCN block with dpg mode

 */

static int vcn_v4_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)

static void vcn_v4_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx)

{

	uint32_t tmp;
@@ -1133,7 +1133,6 @@ static int vcn_v4_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx) 
	/* disable dynamic power gating mode */

	WREG32_P(SOC15_REG_OFFSET(VCN, inst_idx, regUVD_POWER_STATUS), 0,

		~UVD_POWER_STATUS__UVD_PG_MODE_MASK);

	return 0;

}



/**
@@ -1154,7 +1153,7 @@ static int vcn_v4_0_stop(struct amdgpu_device *adev) 
		fw_shared->sq.queue_mode |= FW_QUEUE_DPG_HOLD_OFF;



		if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) {

			r = vcn_v4_0_stop_dpg_mode(adev, i);

			vcn_v4_0_stop_dpg_mode(adev, i);

			continue;

		}