Commit 38461894 authored Nov 17, 2022 by Dan Carpenter Committed by David S. Miller Nov 18, 2022

rxrpc: uninitialized variable in rxrpc_send_ack_packet()



The "pkt" was supposed to have been deleted in a previous patch.  It
leads to an uninitialized variable bug.

Fixes: 72f0c6fb ("rxrpc: Allocate ACK records at proposal and queue for transmission")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 101c1bb6

net/rxrpc/output.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -202,7 +202,6 @@ static void rxrpc_cancel_rtt_probe(struct rxrpc_call *call,
		static int rxrpc_send_ack_packet(struct rxrpc_local local, struct rxrpc_txbuf txb)
		{
		struct rxrpc_connection *conn;
		struct rxrpc_ack_buffer *pkt;
		struct rxrpc_call *call = txb->call;
		struct msghdr msg;
		struct kvec iov[1];
		@@ -270,7 +269,6 @@ static int rxrpc_send_ack_packet(struct rxrpc_local local, struct rxrpc_txbuf
		rxrpc_set_keepalive(call);
		}

		kfree(pkt);
		return ret;
		}