Commit 101c1bb6 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

rxrpc: fix rxkad_verify_response() 



The error handling for if skb_copy_bits() fails was accidentally deleted
so the rxkad_decrypt_ticket() function is not called.

Fixes: 5d7edbc9 ("rxrpc: Get rid of the Rx ring")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ec8cd134

net/rxrpc/rxkad.c

+4 −2
Original line number Diff line number Diff line
@@ -1165,8 +1165,10 @@ static int rxkad_verify_response(struct rxrpc_connection *conn, 


	eproto = tracepoint_string("rxkad_tkt_short");

	abort_code = RXKADPACKETSHORT;

	if (skb_copy_bits(skb, sizeof(struct rxrpc_wire_header) + sizeof(*response),

			  ticket, ticket_len) < 0)

	ret = skb_copy_bits(skb, sizeof(struct rxrpc_wire_header) + sizeof(*response),

			    ticket, ticket_len);

	if (ret < 0)

		goto temporary_error_free_ticket;



	ret = rxkad_decrypt_ticket(conn, server_key, skb, ticket, ticket_len,

				   &session_key, &expiry, _abort_code);