Commit 36bde9c1 authored by Wei Fang's avatar Wei Fang Committed by Jakub Kicinski
Browse files

net: fec: remove fec_set_mac_address() from fec_enet_init() 



The fec_enet_init() is only invoked when the FEC driver probes, and
the network device of FEC is not been brought up at this moment. So
the fec_set_mac_address() does nothing and just returns zero when it
is invoked in the fec_enet_init(). Actually, the MAC address is set
into the hardware through fec_restart() which is also called in the
fec_enet_init().

Signed-off-by: default avatarWei Fang <wei.fang@nxp.com>
Link: https://lore.kernel.org/r/20230718090928.2654347-3-wei.fang@nxp.com


Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3b23ecd5

drivers/net/ethernet/freescale/fec_main.c

+0 −3
Original line number Diff line number Diff line
@@ -3966,9 +3966,6 @@ static int fec_enet_init(struct net_device *ndev) 
	if (ret)

		goto free_queue_mem;



	/* make sure MAC we just acquired is programmed into the hw */

	fec_set_mac_address(ndev, NULL);



	/* Set receive and transmit descriptor base. */

	for (i = 0; i < fep->num_rx_queues; i++) {

		struct fec_enet_priv_rx_q *rxq = fep->rx_queue[i];