Commit 3b23ecd5 authored by Wei Fang's avatar Wei Fang Committed by Jakub Kicinski
Browse files

net: fec: remove the remaining code of rx copybreak 



Since the commit 95698ff6 ("net: fec: using page pool to manage
RX buffers") has been applied, all the rx packets, no matter small
packets or large packets are put directly into the kernel networking
buffers. That is to say, the rx copybreak function has been removed
since then, but the related code has not been completely cleaned up.
So the purpose of this patch is to clean up the remaining related
code of rx copybreak.

Signed-off-by: default avatarWei Fang <wei.fang@nxp.com>
Link: https://lore.kernel.org/r/20230718090928.2654347-2-wei.fang@nxp.com


Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 51318bf4

drivers/net/ethernet/freescale/fec.h

+0 −2
Original line number Diff line number Diff line
@@ -679,8 +679,6 @@ struct fec_enet_private { 
	struct ethtool_eee eee;

	unsigned int clk_ref_rate;



	u32 rx_copybreak;



	/* ptp clock period in ns*/

	unsigned int ptp_inc;

drivers/net/ethernet/freescale/fec_main.c

+0 −43
Original line number Diff line number Diff line
@@ -325,8 +325,6 @@ MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC address"); 
#define FEC_WOL_FLAG_ENABLE		(0x1 << 1)

#define FEC_WOL_FLAG_SLEEP_ON		(0x1 << 2)



#define COPYBREAK_DEFAULT	256



/* Max number of allowed TCP segments for software TSO */

#define FEC_MAX_TSO_SEGS	100

#define FEC_MAX_SKB_DESCS	(FEC_MAX_TSO_SEGS * 2 + MAX_SKB_FRAGS)
@@ -3051,44 +3049,6 @@ static int fec_enet_set_coalesce(struct net_device *ndev, 
	return 0;

}



static int fec_enet_get_tunable(struct net_device *netdev,

				const struct ethtool_tunable *tuna,

				void *data)

{

	struct fec_enet_private *fep = netdev_priv(netdev);

	int ret = 0;



	switch (tuna->id) {

	case ETHTOOL_RX_COPYBREAK:

		*(u32 *)data = fep->rx_copybreak;

		break;

	default:

		ret = -EINVAL;

		break;

	}



	return ret;

}



static int fec_enet_set_tunable(struct net_device *netdev,

				const struct ethtool_tunable *tuna,

				const void *data)

{

	struct fec_enet_private *fep = netdev_priv(netdev);

	int ret = 0;



	switch (tuna->id) {

	case ETHTOOL_RX_COPYBREAK:

		fep->rx_copybreak = *(u32 *)data;

		break;

	default:

		ret = -EINVAL;

		break;

	}



	return ret;

}



/* LPI Sleep Ts count base on tx clk (clk_ref).

 * The lpi sleep cnt value = X us / (cycle_ns).

 */
@@ -3226,8 +3186,6 @@ static const struct ethtool_ops fec_enet_ethtool_ops = { 
	.get_sset_count		= fec_enet_get_sset_count,

#endif

	.get_ts_info		= fec_enet_get_ts_info,

	.get_tunable		= fec_enet_get_tunable,

	.set_tunable		= fec_enet_set_tunable,

	.get_wol		= fec_enet_get_wol,

	.set_wol		= fec_enet_set_wol,

	.get_eee		= fec_enet_get_eee,
@@ -4476,7 +4434,6 @@ fec_probe(struct platform_device *pdev) 
	if (fep->bufdesc_ex && fep->ptp_clock)

		netdev_info(ndev, "registered PHC device %d\n", fep->dev_id);



	fep->rx_copybreak = COPYBREAK_DEFAULT;

	INIT_WORK(&fep->tx_timeout_work, fec_enet_timeout_work);



	pm_runtime_mark_last_busy(&pdev->dev);