HID: logitech-dj: Fix error handling in logi_dj_recv_switch_to_dj_mode()
stable inclusion from stable-v5.10.195 commit e38a6f12685d8a2189b72078f6254b069ff84650 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I95JOC Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e38a6f12685d8a2189b72078f6254b069ff84650 -------------------------------- [ Upstream commit 6f20d326 ] Presently, if a call to logi_dj_recv_send_report() fails, we do not learn about the error until after sending short HID_OUTPUT_REPORT with hid_hw_raw_request(). To handle this somewhat unlikely issue, return on error in logi_dj_recv_send_report() (minding ugly sleep workaround) and take into account the result of hid_hw_raw_request(). Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: 6a9ddc89 ("HID: logitech-dj: enable notifications on connect/disconnect") Signed-off-by:Nikita Zhandarovich <n.zhandarovich@fintech.ru> Link: https://lore.kernel.org/r/20230613101635.77820-1-n.zhandarovich@fintech.ru Signed-off-by:
Benjamin Tissoires <bentiss@kernel.org> Signed-off-by:
Sasha Levin <sashal@kernel.org> Signed-off-by:
sanglipeng <sanglipeng1@jd.com>
Loading
Please sign in to comment