Commit 3537b4c3 authored by Jan Kara's avatar Jan Kara Committed by Yang Yingliang
Browse files

ext4: Detect already used quota file early



stable inclusion
from linux-4.19.155
commit d808c88f0b88697d7df75eb233b50c235db34b24

--------------------------------

[ Upstream commit e0770e91 ]

When we try to use file already used as a quota file again (for the same
or different quota type), strange things can happen. At the very least
lockdep annotations may be wrong but also inode flags may be wrongly set
/ reset. When the file is used for two quota types at once we can even
corrupt the file and likely crash the kernel. Catch all these cases by
checking whether passed file is already used as quota file and bail
early in that case.

This fixes occasional generic/219 failure due to lockdep complaint.

Reviewed-by: default avatarAndreas Dilger <adilger@dilger.ca>
Reported-by: default avatarRitesh Harjani <riteshh@linux.ibm.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20201015110330.28716-1-jack@suse.cz


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarCheng Jian <cj.chengjian@huawei.com>
parent b33d6739
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment