Commit 3202f482 authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Jiri Kosina
Browse files

HID: hid-sensor-custom: Process failure of sensor_hub_set_feature() 



When user modifies a custom feature value and sensor_hub_set_feature()
fails, return error.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent ca66a677

drivers/hid/hid-sensor-custom.c

+5 −3
Original line number Diff line number Diff line
@@ -387,7 +387,7 @@ static ssize_t store_value(struct device *dev, struct device_attribute *attr, 
	struct hid_sensor_custom *sensor_inst = dev_get_drvdata(dev);

	int index, field_index, usage;

	char name[HID_CUSTOM_NAME_LENGTH];

	int value;

	int value, ret;



	if (sscanf(attr->attr.name, "feature-%x-%x-%s", &index, &usage,

		   name) == 3) {
@@ -403,8 +403,10 @@ static ssize_t store_value(struct device *dev, struct device_attribute *attr, 


		report_id = sensor_inst->fields[field_index].attribute.

								report_id;

		sensor_hub_set_feature(sensor_inst->hsdev, report_id,

		ret = sensor_hub_set_feature(sensor_inst->hsdev, report_id,

					     index, sizeof(value), &value);

		if (ret)

			return ret;

	} else

		return -EINVAL;