Commit ca66a677 authored by Johnny Chuang's avatar Johnny Chuang Committed by Benjamin Tissoires
Browse files

HID: i2c-hid: Skip ELAN power-on command after reset 



For ELAN touchscreen, we found our boot code of IC was not flexible enough
to receive and handle this command.
Once the FW main code of our controller is crashed for some reason,
the controller could not be enumerated successfully to be recognized
by the system host. therefore, it lost touch functionality.

Add quirk for skip send power-on command after reset.
It will impact to ELAN touchscreen and touchpad on HID over I2C projects.

Fixes: 43b7029f ("HID: i2c-hid: Send power-on command after reset").

Cc: stable@vger.kernel.org
Signed-off-by: default avatarJohnny Chuang <johnny.chuang.emc@gmail.com>
Reviewed-by: default avatarHarry Cutts <hcutts@chromium.org>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Tested-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
parent 6be388f4

drivers/hid/i2c-hid/i2c-hid-core.c

+8 −1
Original line number Diff line number Diff line
@@ -45,6 +45,7 @@ 
#define I2C_HID_QUIRK_BOGUS_IRQ			BIT(4)

#define I2C_HID_QUIRK_RESET_ON_RESUME		BIT(5)

#define I2C_HID_QUIRK_BAD_INPUT_SIZE		BIT(6)

#define I2C_HID_QUIRK_NO_WAKEUP_AFTER_RESET	BIT(7)





/* flags */
@@ -178,6 +179,11 @@ static const struct i2c_hid_quirks { 
		 I2C_HID_QUIRK_RESET_ON_RESUME },

	{ USB_VENDOR_ID_ITE, I2C_DEVICE_ID_ITE_LENOVO_LEGION_Y720,

		I2C_HID_QUIRK_BAD_INPUT_SIZE },

	/*

	 * Sending the wakeup after reset actually break ELAN touchscreen controller

	 */

	{ USB_VENDOR_ID_ELAN, HID_ANY_ID,

		 I2C_HID_QUIRK_NO_WAKEUP_AFTER_RESET },

	{ 0, 0 }

};
@@ -461,6 +467,7 @@ static int i2c_hid_hwreset(struct i2c_client *client) 
	}



	/* At least some SIS devices need this after reset */

	if (!(ihid->quirks & I2C_HID_QUIRK_NO_WAKEUP_AFTER_RESET))

		ret = i2c_hid_set_power(client, I2C_HID_PWR_ON);



out_unlock: