Commit 30531e14 authored by Zhu Wang's avatar Zhu Wang Committed by Bartosz Golaszewski
Browse files

gpio: raspberrypi-exp: remove redundant of_match_ptr() 



The driver depends on CONFIG_OF, so it is not necessary to use
of_match_ptr() here, and __maybe_unused can also be removed.

Even for drivers that do not depend on CONFIG_OF, it's almost always
better to leave out the of_match_ptr(), since the only thing it can
possibly do is to save a few bytes of .text if a driver can be used both
with and without it.

Signed-off-by: default avatarZhu Wang <wangzhu9@huawei.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 58787538

drivers/gpio/gpio-raspberrypi-exp.c

+2 −2
Original line number Diff line number Diff line
@@ -234,7 +234,7 @@ static int rpi_exp_gpio_probe(struct platform_device *pdev) 
	return devm_gpiochip_add_data(dev, &rpi_gpio->gc, rpi_gpio);

}



static const struct of_device_id rpi_exp_gpio_ids[] __maybe_unused = {

static const struct of_device_id rpi_exp_gpio_ids[] = {

	{ .compatible = "raspberrypi,firmware-gpio" },

	{ }

};
@@ -243,7 +243,7 @@ MODULE_DEVICE_TABLE(of, rpi_exp_gpio_ids); 
static struct platform_driver rpi_exp_gpio_driver = {

	.driver	= {

		.name		= MODULE_NAME,

		.of_match_table	= of_match_ptr(rpi_exp_gpio_ids),

		.of_match_table	= rpi_exp_gpio_ids,

	},

	.probe	= rpi_exp_gpio_probe,

};