Commit 58787538 authored by Zhu Wang's avatar Zhu Wang Committed by Bartosz Golaszewski
Browse files

gpio: max3191x: remove redundant of_match_ptr() 



The driver depends on CONFIG_OF, so it is not necessary to use CONFIG_OF
and of_match_ptr() here, we remove them all.

Even for drivers that do not depend on CONFIG_OF, it's almost always
better to leave out the of_match_ptr(), since the only thing it can
possibly do is to save a few bytes of .text if a driver can be used both
with and without it.

Signed-off-by: default avatarZhu Wang <wangzhu9@huawei.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent bcb6b9e5

drivers/gpio/gpio-max3191x.c

+1 −3
Original line number Diff line number Diff line
@@ -457,7 +457,6 @@ static int __init max3191x_register_driver(struct spi_driver *sdrv) 
	return spi_register_driver(sdrv);

}



#ifdef CONFIG_OF

static const struct of_device_id max3191x_of_id[] = {

	{ .compatible = "maxim,max31910" },

	{ .compatible = "maxim,max31911" },
@@ -468,7 +467,6 @@ static const struct of_device_id max3191x_of_id[] = { 
	{ }

};

MODULE_DEVICE_TABLE(of, max3191x_of_id);

#endif



static const struct spi_device_id max3191x_spi_id[] = {

	{ "max31910" },
@@ -484,7 +482,7 @@ MODULE_DEVICE_TABLE(spi, max3191x_spi_id); 
static struct spi_driver max3191x_driver = {

	.driver = {

		.name		= "max3191x",

		.of_match_table	= of_match_ptr(max3191x_of_id),

		.of_match_table	= max3191x_of_id,

	},

	.probe	  = max3191x_probe,

	.remove	  = max3191x_remove,