Commit 2f040a17 authored by Pali Rohár's avatar Pali Rohár Committed by Lorenzo Pieralisi
Browse files

PCI: aardvark: Fix memory leak in driver unbind 

Free config space for emulated root bridge when unbinding driver to fix
memory leak. Do it after disabling and masking all interrupts, since
aardvark interrupt handler accesses config space of emulated root
bridge.

Link: https://lore.kernel.org/r/20211130172913.9727-9-kabel@kernel.org


Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarMarek Behún <kabel@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
parent 13bcdf07

drivers/pci/controller/pci-aardvark.c

+3 −0
Original line number Diff line number Diff line
@@ -1734,6 +1734,9 @@ static int advk_pcie_remove(struct platform_device *pdev) 
	advk_pcie_remove_msi_irq_domain(pcie);

	advk_pcie_remove_irq_domain(pcie);



	/* Free config space for emulated root bridge */

	pci_bridge_emul_cleanup(&pcie->bridge);



	/* Disable outbound address windows mapping */

	for (i = 0; i < OB_WIN_COUNT; i++)

		advk_pcie_disable_ob_win(pcie, i);