Commit 13bcdf07 authored by Pali Rohár's avatar Pali Rohár Committed by Lorenzo Pieralisi
Browse files

PCI: aardvark: Mask all interrupts when unbinding driver 

Ensure that no interrupt can be triggered after driver unbind.

Link: https://lore.kernel.org/r/20211130172913.9727-8-kabel@kernel.org


Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarMarek Behún <kabel@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
parent a46f2f6d

drivers/pci/controller/pci-aardvark.c

+21 −0
Original line number Diff line number Diff line
@@ -1709,6 +1709,27 @@ static int advk_pcie_remove(struct platform_device *pdev) 
	val &= ~(PCI_COMMAND_IO | PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER);

	advk_writel(pcie, val, PCIE_CORE_CMD_STATUS_REG);



	/* Disable MSI */

	val = advk_readl(pcie, PCIE_CORE_CTRL2_REG);

	val &= ~PCIE_CORE_CTRL2_MSI_ENABLE;

	advk_writel(pcie, val, PCIE_CORE_CTRL2_REG);



	/* Clear MSI address */

	advk_writel(pcie, 0, PCIE_MSI_ADDR_LOW_REG);

	advk_writel(pcie, 0, PCIE_MSI_ADDR_HIGH_REG);



	/* Mask all interrupts */

	advk_writel(pcie, PCIE_MSI_ALL_MASK, PCIE_MSI_MASK_REG);

	advk_writel(pcie, PCIE_ISR0_ALL_MASK, PCIE_ISR0_MASK_REG);

	advk_writel(pcie, PCIE_ISR1_ALL_MASK, PCIE_ISR1_MASK_REG);

	advk_writel(pcie, PCIE_IRQ_ALL_MASK, HOST_CTRL_INT_MASK_REG);



	/* Clear all interrupts */

	advk_writel(pcie, PCIE_MSI_ALL_MASK, PCIE_MSI_STATUS_REG);

	advk_writel(pcie, PCIE_ISR0_ALL_MASK, PCIE_ISR0_REG);

	advk_writel(pcie, PCIE_ISR1_ALL_MASK, PCIE_ISR1_REG);

	advk_writel(pcie, PCIE_IRQ_ALL_MASK, HOST_CTRL_INT_STATUS_REG);



	/* Remove IRQ domains */

	advk_pcie_remove_msi_irq_domain(pcie);

	advk_pcie_remove_irq_domain(pcie);