Commit 2d1e72f2 authored Sep 03, 2021 by Nitesh Narayan Lal Committed by Thomas Gleixner Dec 10, 2021

hinic: Use irq_set_affinity_and_hint()



The driver uses irq_set_affinity_hint() to:

 - Set the affinity_hint which is consumed by the userspace for
   distributing the interrupts

 - Enforce affinity

As per commit 352f58b0 ("net-next/hinic: Set Rxq irq to specific cpu
for NUMA"), the hinic driver enforces its own affinity to bind IRQs to the
local NUMA node. However, irq_set_affinity_hint() applying the provided
cpumask as an affinity for the interrupt is an undocumented side effect.

To remove this side effect irq_set_affinity_hint() has been marked as
deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
where the provided mask needs to be applied as the affinity and
affinity_hint pointer needs to be set and replace with
irq_update_affinity_hint() where only affinity_hint needs to be updated.

Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210903152430.244937-13-nitesh@redhat.com

parent ce5a58a9

drivers/net/ethernet/huawei/hinic/hinic_rx.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -548,7 +548,7 @@ static int rx_request_irq(struct hinic_rxq *rxq)
		goto err_req_irq;

		cpumask_set_cpu(qp->q_id % num_online_cpus(), &rq->affinity_mask);
		err = irq_set_affinity_hint(rq->irq, &rq->affinity_mask);
		err = irq_set_affinity_and_hint(rq->irq, &rq->affinity_mask);
		if (err)
		goto err_irq_affinity;

		@@ -565,7 +565,7 @@ static void rx_free_irq(struct hinic_rxq *rxq)
		{
		struct hinic_rq *rq = rxq->rq;

		irq_set_affinity_hint(rq->irq, NULL);
		irq_update_affinity_hint(rq->irq, NULL);
		free_irq(rq->irq, rxq);
		rx_del_napi(rxq);
		}