Commit ce5a58a9 authored by Nitesh Narayan Lal's avatar Nitesh Narayan Lal Committed by Thomas Gleixner
Browse files

scsi: lpfc: Use irq_set_affinity() 



The driver uses irq_set_affinity_hint to set the affinity for the lpfc
interrupts to a mask corresponding to the local NUMA node to avoid
performance overhead on AMD architectures.

However, irq_set_affinity_hint() setting the affinity is an undocumented
side effect that this function also sets the affinity under the hood.
To remove this side effect irq_set_affinity_hint() has been marked as
deprecated and new interfaces have been introduced.

Also, as per the commit dcaa2136 ("scsi: lpfc: Change default IRQ model
on AMD architectures"):
"On AMD architecture, revert the irq allocation to the normal style
(non-managed) and then use irq_set_affinity_hint() to set the cpu affinity
and disable user-space rebalancing."
we don't really need to set the affinity_hint as user-space rebalancing for
the lpfc interrupts is not desired.

Hence, replace the irq_set_affinity_hint() with irq_set_affinity() which
only applies the affinity for the interrupts.

Signed-off-by: default avatarNitesh Narayan Lal <nitesh@redhat.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarJames Smart <jsmart2021@gmail.com>
Link: https://lore.kernel.org/r/20210903152430.244937-12-nitesh@redhat.com
parent bf886e1e

drivers/scsi/lpfc/lpfc_init.c

+1 −3
Original line number Diff line number Diff line
@@ -12709,7 +12709,7 @@ lpfc_irq_set_aff(struct lpfc_hba_eq_hdl *eqhdl, unsigned int cpu) 
	cpumask_clear(&eqhdl->aff_mask);

	cpumask_set_cpu(cpu, &eqhdl->aff_mask);

	irq_set_status_flags(eqhdl->irq, IRQ_NO_BALANCING);

	irq_set_affinity_hint(eqhdl->irq, &eqhdl->aff_mask);

	irq_set_affinity(eqhdl->irq, &eqhdl->aff_mask);

}



/**
@@ -12998,7 +12998,6 @@ lpfc_sli4_enable_msix(struct lpfc_hba *phba) 
	for (--index; index >= 0; index--) {

		eqhdl = lpfc_get_eq_hdl(index);

		lpfc_irq_clear_aff(eqhdl);

		irq_set_affinity_hint(eqhdl->irq, NULL);

		free_irq(eqhdl->irq, eqhdl);

	}
@@ -13159,7 +13158,6 @@ lpfc_sli4_disable_intr(struct lpfc_hba *phba) 
		for (index = 0; index < phba->cfg_irq_chann; index++) {

			eqhdl = lpfc_get_eq_hdl(index);

			lpfc_irq_clear_aff(eqhdl);

			irq_set_affinity_hint(eqhdl->irq, NULL);

			free_irq(eqhdl->irq, eqhdl);

		}

	} else {