Commit 2bee255a authored by Baruch Siach's avatar Baruch Siach Committed by Bartosz Golaszewski
Browse files

gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX 



PWM on/off registers are limited to UINT_MAX. However the state period
and duty_cycle fields are ns values of type u64. There is no reason to
limit them to UINT_MAX.

Reported-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarBaruch Siach <baruch@tkos.co.il>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent de1eaf60

drivers/gpio/gpio-mvebu.c

+2 −6
Original line number Diff line number Diff line
@@ -669,9 +669,7 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip, 
	regmap_read(mvpwm->regs, mvebu_pwmreg_blink_on_duration(mvpwm), &u);

	val = (unsigned long long) u * NSEC_PER_SEC;

	val = DIV_ROUND_UP_ULL(val, mvpwm->clk_rate);

	if (val > UINT_MAX)

		state->duty_cycle = UINT_MAX;

	else if (val)

	if (val)

		state->duty_cycle = val;

	else

		state->duty_cycle = 1;
@@ -681,9 +679,7 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip, 
	val += (unsigned long long) u; /* period = on + off duration */

	val *= NSEC_PER_SEC;

	val = DIV_ROUND_UP_ULL(val, mvpwm->clk_rate);

	if (val > UINT_MAX)

		state->period = UINT_MAX;

	else if (val)

	if (val)

		state->period = val;

	else

		state->period = 1;