Commit 2af4b918 authored by Sergey Organov's avatar Sergey Organov Committed by Greg Kroah-Hartman
Browse files

serial: imx: refine local variables in rxint() 



The 'rx' is chip register, similar to 'usr2', so let it be of 'u32' type as
well.

Move 'flg' to be FIFO read loop local as it's not used outside.

Signed-off-by: default avatarSergey Organov <sorganov@gmail.com>
Link: https://lore.kernel.org/r/20230201142700.4346-8-sorganov@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 53701b6d

drivers/tty/serial/imx.c

+2 −3
Original line number Diff line number Diff line
@@ -890,9 +890,8 @@ static void imx_uart_check_flood(struct imx_port *sport, u32 usr2) 
static irqreturn_t __imx_uart_rxint(int irq, void *dev_id)

{

	struct imx_port *sport = dev_id;

	unsigned int rx, flg;

	struct tty_port *port = &sport->port.state->port;

	u32 usr2;

	u32 usr2, rx;



	/* If we received something, check for 0xff flood */

	usr2 = imx_uart_readl(sport, USR2);
@@ -900,7 +899,7 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) 
		imx_uart_check_flood(sport, usr2);



	while ((rx = imx_uart_readl(sport, URXD0)) & URXD_CHARRDY) {

		flg = TTY_NORMAL;

		unsigned int flg = TTY_NORMAL;

		sport->port.icount.rx++;



		if (unlikely(rx & URXD_ERR)) {