Commit 53701b6d authored by Sergey Organov's avatar Sergey Organov Committed by Greg Kroah-Hartman
Browse files

serial: imx: stop using USR2 in FIFO reading loop 



The chip provides all the needed bits in the URXD0 register that we read
anyway for data, so get rid of reading USR2 and use only URXD0 bits
instead.

Signed-off-by: default avatarSergey Organov <sorganov@gmail.com>
Link: https://lore.kernel.org/r/20230201142700.4346-7-sorganov@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0fbca479

drivers/tty/serial/imx.c

+6 −12
Original line number Diff line number Diff line
@@ -894,27 +894,21 @@ static irqreturn_t __imx_uart_rxint(int irq, void *dev_id) 
	struct tty_port *port = &sport->port.state->port;

	u32 usr2;



	usr2 = imx_uart_readl(sport, USR2);



	/* If we received something, check for 0xff flood */

	usr2 = imx_uart_readl(sport, USR2);

	if (usr2 & USR2_RDR)

		imx_uart_check_flood(sport, usr2);



	for ( ; usr2 & USR2_RDR; usr2 = imx_uart_readl(sport, USR2)) {

	while ((rx = imx_uart_readl(sport, URXD0)) & URXD_CHARRDY) {

		flg = TTY_NORMAL;

		sport->port.icount.rx++;



		rx = imx_uart_readl(sport, URXD0);



		if (usr2 & USR2_BRCD) {

			imx_uart_writel(sport, USR2_BRCD, USR2);

		if (unlikely(rx & URXD_ERR)) {

			if (rx & URXD_BRK) {

				sport->port.icount.brk++;

				if (uart_handle_break(&sport->port))

					continue;

			}



		if (unlikely(rx & URXD_ERR)) {

			if (rx & URXD_BRK)

				sport->port.icount.brk++;

			else if (rx & URXD_PRERR)

				sport->port.icount.parity++;

			else if (rx & URXD_FRMERR)