Commit 29fd3ca1 authored by Minghao Chi's avatar Minghao Chi Committed by Paolo Abeni
Browse files

qed: Remove unnecessary synchronize_irq() before free_irq() 



Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.

Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarMinghao Chi <chi.minghao@zte.com.cn>
Link: https://lore.kernel.org/r/20220516072646.1651109-1-chi.minghao@zte.com.cn


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent a968c799

drivers/net/ethernet/qlogic/qed/qed_main.c

+0 −1
Original line number Diff line number Diff line
@@ -823,7 +823,6 @@ static void qed_slowpath_irq_free(struct qed_dev *cdev) 
		for_each_hwfn(cdev, i) {

			if (!cdev->hwfns[i].b_int_requested)

				break;

			synchronize_irq(cdev->int_params.msix_table[i].vector);

			free_irq(cdev->int_params.msix_table[i].vector,

				 &cdev->hwfns[i].sp_dpc);

		}