Commit a968c799 authored by Lu Wei's avatar Lu Wei Committed by Paolo Abeni
Browse files

ax25: merge repeat codes in ax25_dev_device_down() 



Merge repeat codes to reduce the duplication.

Signed-off-by: default avatarLu Wei <luwei32@huawei.com>
Link: https://lore.kernel.org/r/20220516062804.254742-1-luwei32@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent bcdcf2c4

net/ax25/ax25_dev.c

+10 −12
Original line number Diff line number Diff line
@@ -115,29 +115,27 @@ void ax25_dev_device_down(struct net_device *dev) 


	if ((s = ax25_dev_list) == ax25_dev) {

		ax25_dev_list = s->next;

		spin_unlock_bh(&ax25_dev_lock);

		ax25_dev_put(ax25_dev);

		dev->ax25_ptr = NULL;

		dev_put_track(dev, &ax25_dev->dev_tracker);

		ax25_dev_put(ax25_dev);

		return;

		goto unlock_put;

	}



	while (s != NULL && s->next != NULL) {

		if (s->next == ax25_dev) {

			s->next = ax25_dev->next;

			goto unlock_put;

		}



		s = s->next;

	}

	spin_unlock_bh(&ax25_dev_lock);

			ax25_dev_put(ax25_dev);

	dev->ax25_ptr = NULL;

			dev_put_track(dev, &ax25_dev->dev_tracker);

	ax25_dev_put(ax25_dev);

	return;

		}



		s = s->next;

	}

unlock_put:

	spin_unlock_bh(&ax25_dev_lock);

	ax25_dev_put(ax25_dev);

	dev->ax25_ptr = NULL;

	dev_put_track(dev, &ax25_dev->dev_tracker);

	ax25_dev_put(ax25_dev);

}