Commit 28e3dc8f authored by Tom Rix's avatar Tom Rix Committed by Bjorn Andersson
Browse files

soc: qcom: pdr: use static for servreg_* variables 



Sparse reports this repesentative issue
pdr_internal.h:31:22: warning: symbol 'servreg_location_entry_ei' was not declared. Should it be static?
Similar for other servreg_*

Global variables should not be defined in header files.
This only works because pdr_internal.h is only included
by pdr_interface.c.  Single file use variables should be
static so add static to their storage-class specifiers.

Signed-off-by: default avatarTom Rix <trix@redhat.com>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220422173806.21982-1-trix@redhat.com
parent ec69dfbd

drivers/soc/qcom/pdr_internal.h

+10 −10
Original line number Diff line number Diff line
@@ -28,7 +28,7 @@ struct servreg_location_entry { 
	u32 instance;

};



struct qmi_elem_info servreg_location_entry_ei[] = {

static struct qmi_elem_info servreg_location_entry_ei[] = {

	{

		.data_type      = QMI_STRING,

		.elem_len       = SERVREG_NAME_LENGTH + 1,
@@ -74,7 +74,7 @@ struct servreg_get_domain_list_req { 
	u32 domain_offset;

};



struct qmi_elem_info servreg_get_domain_list_req_ei[] = {

static struct qmi_elem_info servreg_get_domain_list_req_ei[] = {

	{

		.data_type      = QMI_STRING,

		.elem_len       = SERVREG_NAME_LENGTH + 1,
@@ -116,7 +116,7 @@ struct servreg_get_domain_list_resp { 
	struct servreg_location_entry domain_list[SERVREG_DOMAIN_LIST_LENGTH];

};



struct qmi_elem_info servreg_get_domain_list_resp_ei[] = {

static struct qmi_elem_info servreg_get_domain_list_resp_ei[] = {

	{

		.data_type      = QMI_STRUCT,

		.elem_len       = 1,
@@ -199,7 +199,7 @@ struct servreg_register_listener_req { 
	char service_path[SERVREG_NAME_LENGTH + 1];

};



struct qmi_elem_info servreg_register_listener_req_ei[] = {

static struct qmi_elem_info servreg_register_listener_req_ei[] = {

	{

		.data_type      = QMI_UNSIGNED_1_BYTE,

		.elem_len       = 1,
@@ -227,7 +227,7 @@ struct servreg_register_listener_resp { 
	enum servreg_service_state curr_state;

};



struct qmi_elem_info servreg_register_listener_resp_ei[] = {

static struct qmi_elem_info servreg_register_listener_resp_ei[] = {

	{

		.data_type      = QMI_STRUCT,

		.elem_len       = 1,
@@ -263,7 +263,7 @@ struct servreg_restart_pd_req { 
	char service_path[SERVREG_NAME_LENGTH + 1];

};



struct qmi_elem_info servreg_restart_pd_req_ei[] = {

static struct qmi_elem_info servreg_restart_pd_req_ei[] = {

	{

		.data_type      = QMI_STRING,

		.elem_len       = SERVREG_NAME_LENGTH + 1,
@@ -280,7 +280,7 @@ struct servreg_restart_pd_resp { 
	struct qmi_response_type_v01 resp;

};



struct qmi_elem_info servreg_restart_pd_resp_ei[] = {

static struct qmi_elem_info servreg_restart_pd_resp_ei[] = {

	{

		.data_type      = QMI_STRUCT,

		.elem_len       = 1,
@@ -300,7 +300,7 @@ struct servreg_state_updated_ind { 
	u16 transaction_id;

};



struct qmi_elem_info servreg_state_updated_ind_ei[] = {

static struct qmi_elem_info servreg_state_updated_ind_ei[] = {

	{

		.data_type      = QMI_SIGNED_4_BYTE_ENUM,

		.elem_len       = 1,
@@ -336,7 +336,7 @@ struct servreg_set_ack_req { 
	u16 transaction_id;

};



struct qmi_elem_info servreg_set_ack_req_ei[] = {

static struct qmi_elem_info servreg_set_ack_req_ei[] = {

	{

		.data_type      = QMI_STRING,

		.elem_len       = SERVREG_NAME_LENGTH + 1,
@@ -362,7 +362,7 @@ struct servreg_set_ack_resp { 
	struct qmi_response_type_v01 resp;

};



struct qmi_elem_info servreg_set_ack_resp_ei[] = {

static struct qmi_elem_info servreg_set_ack_resp_ei[] = {

	{

		.data_type      = QMI_STRUCT,

		.elem_len       = 1,