Commit 27c74686 authored by Alexander Aring's avatar Alexander Aring Committed by Stefan Schmidt
Browse files

net: ieee802154: fix nl802154 del llsec devkey 



This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVKEY is
not set by the user. If this is the case nl802154 will return -EINVAL.

Reported-by: default avatar <syzbot+368672e0da240db53b5f@syzkaller.appspotmail.com>
Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20210221174321.14210-4-aahringo@redhat.com


Signed-off-by: default avatarStefan Schmidt <stefan@datenfreihafen.org>
parent 20d5fe2d

net/ieee802154/nl802154.c

+2 −1
Original line number Diff line number Diff line
@@ -1916,7 +1916,8 @@ static int nl802154_del_llsec_devkey(struct sk_buff *skb, struct genl_info *info 
	struct ieee802154_llsec_device_key key;

	__le64 extended_addr;



	if (nla_parse_nested_deprecated(attrs, NL802154_DEVKEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVKEY], nl802154_devkey_policy, info->extack))

	if (!info->attrs[NL802154_ATTR_SEC_DEVKEY] ||

	    nla_parse_nested_deprecated(attrs, NL802154_DEVKEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVKEY], nl802154_devkey_policy, info->extack))

		return -EINVAL;



	if (!attrs[NL802154_DEVKEY_ATTR_EXTENDED_ADDR])