Commit 27527a3d authored by Lad Prabhakar's avatar Lad Prabhakar Committed by Geert Uytterhoeven
Browse files

clk: renesas: rzg2l: Check return value of pm_genpd_init() 



Make sure we check the return value of pm_genpd_init() which might fail.
Also add a devres action to remove the power-domain in-case the probe
callback fails further down in the code flow.

Fixes: ef3c613c ("clk: renesas: Add CPG core wrapper for RZ/G2L SoC")
Signed-off-by: default avatarLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/r/20211117115101.28281-2-prabhakar.mahadev-lad.rj@bp.renesas.com


Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
parent e7d960cd

drivers/clk/renesas/rzg2l-cpg.c

+13 −1
Original line number Diff line number Diff line
@@ -851,10 +851,16 @@ static void rzg2l_cpg_detach_dev(struct generic_pm_domain *unused, struct device 
		pm_clk_destroy(dev);

}



static void rzg2l_cpg_genpd_remove(void *data)

{

	pm_genpd_remove(data);

}



static int __init rzg2l_cpg_add_clk_domain(struct device *dev)

{

	struct device_node *np = dev->of_node;

	struct generic_pm_domain *genpd;

	int ret;



	genpd = devm_kzalloc(dev, sizeof(*genpd), GFP_KERNEL);

	if (!genpd)
@@ -865,7 +871,13 @@ static int __init rzg2l_cpg_add_clk_domain(struct device *dev) 
		       GENPD_FLAG_ACTIVE_WAKEUP;

	genpd->attach_dev = rzg2l_cpg_attach_dev;

	genpd->detach_dev = rzg2l_cpg_detach_dev;

	pm_genpd_init(genpd, &pm_domain_always_on_gov, false);

	ret = pm_genpd_init(genpd, &pm_domain_always_on_gov, false);

	if (ret)

		return ret;



	ret = devm_add_action_or_reset(dev, rzg2l_cpg_genpd_remove, genpd);

	if (ret)

		return ret;



	of_genpd_add_provider_simple(np, genpd);

	return 0;