Commit 25edb25d authored by Ajay Agarwal's avatar Ajay Agarwal Committed by Bjorn Helgaas
Browse files

PCI/ASPM: Set only ASPM_STATE_L1 when driver enables L1 

Previously pci_enable_link_state(PCIE_LINK_STATE_L1) enabled L1SS as well
as L1.  Enable only ASPM_STATE_L1 when the caller enables L1.

The only current caller is vmd_pm_enable_quirk(), which enables *all* ASPM
states, so this should have no functional effect.

[bhelgaas: commit log]
Link: https://lore.kernel.org/r/20230504111301.229358-3-ajayagarwal@google.com


Signed-off-by: default avatarAjay Agarwal <ajayagarwal@google.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarKuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
parent fb097dcd

drivers/pci/pcie/aspm.c

+1 −2
Original line number Diff line number Diff line
@@ -1173,8 +1173,7 @@ int pci_enable_link_state(struct pci_dev *pdev, int state) 
	if (state & PCIE_LINK_STATE_L0S)

		link->aspm_default |= ASPM_STATE_L0S;

	if (state & PCIE_LINK_STATE_L1)

		/* L1 PM substates require L1 */

		link->aspm_default |= ASPM_STATE_L1 | ASPM_STATE_L1SS;

		link->aspm_default |= ASPM_STATE_L1;

	if (state & PCIE_LINK_STATE_L1_1)

		link->aspm_default |= ASPM_STATE_L1_1;

	if (state & PCIE_LINK_STATE_L1_2)