Commit 24f226da authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

ipv6: addrconf: do not block BH in ipv6_get_ifaddr() 



rcu_read_lock() is enough here, no need to block BH.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 480318a0

net/ipv6/addrconf.c

+3 −3
Original line number Diff line number Diff line
@@ -1922,8 +1922,8 @@ struct inet6_ifaddr *ipv6_get_ifaddr(struct net *net, const struct in6_addr *add 
	unsigned int hash = inet6_addr_hash(net, addr);

	struct inet6_ifaddr *ifp, *result = NULL;



	rcu_read_lock_bh();

	hlist_for_each_entry_rcu_bh(ifp, &inet6_addr_lst[hash], addr_lst) {

	rcu_read_lock();

	hlist_for_each_entry_rcu(ifp, &inet6_addr_lst[hash], addr_lst) {

		if (!net_eq(dev_net(ifp->idev->dev), net))

			continue;

		if (ipv6_addr_equal(&ifp->addr, addr)) {
@@ -1935,7 +1935,7 @@ struct inet6_ifaddr *ipv6_get_ifaddr(struct net *net, const struct in6_addr *add 
			}

		}

	}

	rcu_read_unlock_bh();

	rcu_read_unlock();



	return result;

}