Commit 480318a0 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

ipv6: addrconf: do not block BH in ipv6_chk_addr_and_flags() 



rcu_read_lock() is enough here, as inet6_ifa_finish_destroy()
uses kfree_rcu()

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3f27fb23

net/ipv6/addrconf.c

+3 −3
Original line number Diff line number Diff line
@@ -1844,7 +1844,7 @@ int ipv6_chk_addr_and_flags(struct net *net, const struct in6_addr *addr, 
	struct inet6_ifaddr *ifp;

	u32 ifp_flags;



	rcu_read_lock_bh();

	rcu_read_lock();

	hlist_for_each_entry_rcu(ifp, &inet6_addr_lst[hash], addr_lst) {

		if (!net_eq(dev_net(ifp->idev->dev), net))

			continue;
@@ -1858,12 +1858,12 @@ int ipv6_chk_addr_and_flags(struct net *net, const struct in6_addr *addr, 
		    !(ifp_flags&banned_flags) &&

		    (!dev || ifp->idev->dev == dev ||

		     !(ifp->scope&(IFA_LINK|IFA_HOST) || strict))) {

			rcu_read_unlock_bh();

			rcu_read_unlock();

			return 1;

		}

	}



	rcu_read_unlock_bh();

	rcu_read_unlock();

	return 0;

}

EXPORT_SYMBOL(ipv6_chk_addr_and_flags);