Skip to content
Commit 2411e537 authored by Zou Wei's avatar Zou Wei Committed by Yang Yingliang
Browse files

atm: nicstar: Fix possible use-after-free in nicstar_cleanup()

mainline inclusion
from mainline-v5.14-rc1
commit 34e7434b
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9R4DH
CVE: CVE-2021-47355

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=34e7434ba4e97f4b85c1423a59b2922ba7dff2ea



--------------------------------

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZou Wei <zou_wei@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
parent 505199cb
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment