Commit 23c46bab authored by Xiaohui Zhang's avatar Xiaohui Zhang Committed by Sebastian Reichel
Browse files

power: supply: cros_peripheral: Use struct_size() helper in kzalloc() 



Similar to the handling of cros_usbpd_charger_ec_command in commit 441d38c6
("power: supply: cros_usbpd: Use struct_size() helper in kzalloc()"),
we thought a patch might be needed here as well.

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.

Signed-off-by: default avatarXiaohui Zhang <xiaohuizhang@ruc.edu.cn>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent f7ca2d8c

drivers/power/supply/cros_peripheral_charger.c

+1 −1
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ static int cros_pchg_ec_command(const struct charger_data *charger, 
	struct cros_ec_command *msg;

	int ret;



	msg = kzalloc(sizeof(*msg) + max(outsize, insize), GFP_KERNEL);

	msg = kzalloc(struct_size(msg, data, max(outsize, insize)), GFP_KERNEL);

	if (!msg)

		return -ENOMEM;