Commit 441d38c6 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Sebastian Reichel
Browse files

power: supply: cros_usbpd: Use struct_size() helper in kzalloc() 

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.

Also, address the following sparse warnings:
drivers/power/supply/cros_usbpd-charger.c:107:23: warning: using sizeof on a flexible structure

Link: https://github.com/KSPP/linux/issues/174


Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent e783362e

drivers/power/supply/cros_usbpd-charger.c

+1 −1
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ static int cros_usbpd_charger_ec_command(struct charger_data *charger, 
	struct cros_ec_command *msg;

	int ret;



	msg = kzalloc(sizeof(*msg) + max(outsize, insize), GFP_KERNEL);

	msg = kzalloc(struct_size(msg, data, max(outsize, insize)), GFP_KERNEL);

	if (!msg)

		return -ENOMEM;