Unverified Commit 221034ac authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: max98090: remove duplicate status reads and useless assignmment 



The logic for the jack detection has not changed since the first
commit for this driver. Remove a duplicate read and remove useless
assignment

sound/soc/codecs/max98090.c:2170:6: style: Variable 'reg' is
reassigned a value before the old one has been
used. [redundantAssignment]
 reg = snd_soc_component_read(component, M98090_REG_JACK_STATUS);
     ^

sound/soc/codecs/max98090.c:2161:7: note: reg is assigned
  reg = snd_soc_component_read(component, M98090_REG_JACK_STATUS);
      ^

sound/soc/codecs/max98090.c:2170:6: note: reg is overwritten
 reg = snd_soc_component_read(component, M98090_REG_JACK_STATUS);
     ^

sound/soc/codecs/max98090.c:2170:6: style: Variable 'reg' is
reassigned a value before the old one has been
used. [redundantAssignment]
 reg = snd_soc_component_read(component, M98090_REG_JACK_STATUS);
     ^

sound/soc/codecs/max98090.c:2167:7: note: reg is assigned
  reg = snd_soc_component_read(component, M98090_REG_JACK_STATUS);
      ^

sound/soc/codecs/max98090.c:2170:6: note: reg is overwritten
 reg = snd_soc_component_read(component, M98090_REG_JACK_STATUS);
     ^

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210804192456.278702-2-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f2553d46

sound/soc/codecs/max98090.c

+1 −3
Original line number Diff line number Diff line
@@ -2158,13 +2158,11 @@ static void max98090_jack_work(struct work_struct *work) 


		msleep(50);



		reg = snd_soc_component_read(component, M98090_REG_JACK_STATUS);

		snd_soc_component_read(component, M98090_REG_JACK_STATUS);



		/* Weak pull up allows only insertion detection */

		snd_soc_component_update_bits(component, M98090_REG_JACK_DETECT,

			M98090_JDWK_MASK, M98090_JDWK_MASK);

	} else {

		reg = snd_soc_component_read(component, M98090_REG_JACK_STATUS);

	}



	reg = snd_soc_component_read(component, M98090_REG_JACK_STATUS);