Unverified Commit f2553d46 authored by Takashi Iwai's avatar Takashi Iwai Committed by Mark Brown
Browse files

ASoC: amd: vangogh: Drop superfluous mmap callback 



The mmap callback of vangogh driver just calls the default mmap
handler, and it's superfluous, as the PCM core would call it if not
set.  Let's drop the superfluous mmap callback.

Fixes: 361414dc ("ASoC: amd: add vangogh i2s dma driver pm ops")
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20210804075223.9823-1-tiwai@suse.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent edcade2e

sound/soc/amd/vangogh/acp5x-pcm-dma.c

+0 −8
Original line number Diff line number Diff line
@@ -315,13 +315,6 @@ static int acp5x_dma_new(struct snd_soc_component *component, 
	return 0;

}



static int acp5x_dma_mmap(struct snd_soc_component *component,

			  struct snd_pcm_substream *substream,

			  struct vm_area_struct *vma)

{

	return snd_pcm_lib_default_mmap(substream, vma);

}



static int acp5x_dma_close(struct snd_soc_component *component,

			   struct snd_pcm_substream *substream)

{
@@ -364,7 +357,6 @@ static const struct snd_soc_component_driver acp5x_i2s_component = { 
	.close		= acp5x_dma_close,

	.hw_params	= acp5x_dma_hw_params,

	.pointer	= acp5x_dma_pointer,

	.mmap		= acp5x_dma_mmap,

	.pcm_construct	= acp5x_dma_new,

};