Commit 2195d969 authored by Rickard Strandqvist's avatar Rickard Strandqvist Committed by Christoph Hellwig
Browse files

3w-9xxx.c: Cleaning up missing null-terminate in conjunction with strncpy 



Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
And use the sizeof on the to string rather than strlen on the from string.

Signed-off-by: default avatarRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: default avatarAdam Radford <aradford@gmail.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent acafd0b9

drivers/scsi/3w-9xxx.c

+2 −1
Original line number Diff line number Diff line
@@ -608,7 +608,8 @@ static int twa_check_srl(TW_Device_Extension *tw_dev, int *flashed) 
	}



	/* Load rest of compatibility struct */

	strncpy(tw_dev->tw_compat_info.driver_version, TW_DRIVER_VERSION, strlen(TW_DRIVER_VERSION));

	strlcpy(tw_dev->tw_compat_info.driver_version, TW_DRIVER_VERSION,

		sizeof(tw_dev->tw_compat_info.driver_version));

	tw_dev->tw_compat_info.driver_srl_high = TW_CURRENT_DRIVER_SRL;

	tw_dev->tw_compat_info.driver_branch_high = TW_CURRENT_DRIVER_BRANCH;

	tw_dev->tw_compat_info.driver_build_high = TW_CURRENT_DRIVER_BUILD;