Commit 214e0d8f authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Lorenzo Pieralisi
Browse files

PCI: mediatek: Fix refcount leak in mtk_pcie_subsys_powerup() 

The of_find_compatible_node() function returns a node pointer with
refcount incremented, We should use of_node_put() on it when done
Add the missing of_node_put() to release the refcount.

Link: https://lore.kernel.org/r/20220309091953.5630-1-linmq006@gmail.com


Fixes: 87e8657b ("PCI: mediatek: Add new method to get shared pcie-cfg base address")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: default avatarMiles Chen <miles.chen@mediatek.com>
Acked-by: default avatarRob Herring <robh@kernel.org>
parent 31231092

drivers/pci/controller/pcie-mediatek.c

+1 −0
Original line number Diff line number Diff line
@@ -1008,6 +1008,7 @@ static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie) 
					   "mediatek,generic-pciecfg");

	if (cfg_node) {

		pcie->cfg = syscon_node_to_regmap(cfg_node);

		of_node_put(cfg_node);

		if (IS_ERR(pcie->cfg))

			return PTR_ERR(pcie->cfg);

	}