Commit 21234e3a authored by Dan Carpenter's avatar Dan Carpenter Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix use after free in mlx5e_fs_init() 



Call mlx5e_fs_vlan_free(fs) before kvfree(fs).

Fixes: af8bbf73 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 6514210b

drivers/net/ethernet/mellanox/mlx5/core/en_fs.c

+3 −2
Original line number Diff line number Diff line
@@ -1395,10 +1395,11 @@ struct mlx5e_flow_steering *mlx5e_fs_init(const struct mlx5e_profile *profile, 
	}



	return fs;

err_free_fs:

	kvfree(fs);



err_free_vlan:

	mlx5e_fs_vlan_free(fs);

err_free_fs:

	kvfree(fs);

err:

	return NULL;

}