Commit 6514210b authored by Dan Carpenter's avatar Dan Carpenter Committed by Saeed Mahameed
Browse files

net/mlx5e: kTLS, Use _safe() iterator in mlx5e_tls_priv_tx_list_cleanup() 



Use the list_for_each_entry_safe() macro to prevent dereferencing "obj"
after it has been freed.

Fixes: c4dfe704 ("net/mlx5e: kTLS, Recycle objects of device-offloaded TLS TX connections")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent b868c8fe

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c

+2 −2
Original line number Diff line number Diff line
@@ -246,7 +246,7 @@ static void mlx5e_tls_priv_tx_cleanup(struct mlx5e_ktls_offload_context_tx *priv 
static void mlx5e_tls_priv_tx_list_cleanup(struct mlx5_core_dev *mdev,

					   struct list_head *list, int size)

{

	struct mlx5e_ktls_offload_context_tx *obj;

	struct mlx5e_ktls_offload_context_tx *obj, *n;

	struct mlx5e_async_ctx *bulk_async;

	int i;
@@ -255,7 +255,7 @@ static void mlx5e_tls_priv_tx_list_cleanup(struct mlx5_core_dev *mdev, 
		return;



	i = 0;

	list_for_each_entry(obj, list, list_node) {

	list_for_each_entry_safe(obj, n, list, list_node) {

		mlx5e_tls_priv_tx_cleanup(obj, &bulk_async[i]);

		i++;

	}