Commit 2083bebc authored by Lee Jones's avatar Lee Jones Committed by David S. Miller
Browse files

net: ethernet: 3com: 3c574_cs: Remove set but unused variables 'tx' and 'rx' 



Fixes the following W=1 kernel build warning(s):

 drivers/net/ethernet/3com/3c574_cs.c: In function ‘update_stats’:
 drivers/net/ethernet/3com/3c574_cs.c:954:9: warning: variable ‘tx’ set but not used [-Wunused-but-set-variable]
 954 | u8 rx, tx, up;
 | ^~
 drivers/net/ethernet/3com/3c574_cs.c:954:5: warning: variable ‘rx’ set but not used [-Wunused-but-set-variable]
 954 | u8 rx, tx, up;
 | ^~

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Shannon Nelson <snelson@pensando.io>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Martin Habets <mhabets@solarflare.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Donald Becker <becker@scyld.com>
Cc: David Hinds <dahinds@users.sourceforge.net>
Cc: netdev@vger.kernel.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 45a1553b

drivers/net/ethernet/3com/3c574_cs.c

+3 −3
Original line number Diff line number Diff line
@@ -951,7 +951,7 @@ static struct net_device_stats *el3_get_stats(struct net_device *dev) 
static void update_stats(struct net_device *dev)

{

	unsigned int ioaddr = dev->base_addr;

	u8 rx, tx, up;

	u8 up;



	pr_debug("%s: updating the statistics.\n", dev->name);
@@ -972,8 +972,8 @@ static void update_stats(struct net_device *dev) 
	dev->stats.tx_packets			+= (up&0x30) << 4;

	/* Rx packets   */			   inb(ioaddr + 7);

	/* Tx deferrals */			   inb(ioaddr + 8);

	rx		 			 = inw(ioaddr + 10);

	tx					 = inw(ioaddr + 12);

	/* rx */				   inw(ioaddr + 10);

	/* tx */				   inw(ioaddr + 12);



	EL3WINDOW(4);

	/* BadSSD */				   inb(ioaddr + 12);