Commit 45a1553b authored by Lee Jones's avatar Lee Jones Committed by David S. Miller
Browse files

net: bonding: bond_main: Document 'proto' and rename 'new_active' parameters 



Fixes the following W=1 kernel build warning(s):

 drivers/net/bonding/bond_main.c:329: warning: Function parameter or member 'proto' not described in 'bond_vlan_rx_add_vid'
 drivers/net/bonding/bond_main.c:362: warning: Function parameter or member 'proto' not described in 'bond_vlan_rx_kill_vid'
 drivers/net/bonding/bond_main.c:964: warning: Function parameter or member 'new_active' not described in 'bond_change_active_slave'
 drivers/net/bonding/bond_main.c:964: warning: Excess function parameter 'new' description in 'bond_change_active_slave'

Cc: Jay Vosburgh <j.vosburgh@gmail.com>
Cc: Veaceslav Falico <vfalico@gmail.com>
Cc: Andy Gospodarek <andy@greyhouse.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Thomas Davis <tadavis@lbl.gov>
Cc: netdev@vger.kernel.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a35e5478

drivers/net/bonding/bond_main.c

+3 −1
Original line number Diff line number Diff line
@@ -322,6 +322,7 @@ netdev_tx_t bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb, 
/**

 * bond_vlan_rx_add_vid - Propagates adding an id to slaves

 * @bond_dev: bonding net device that got called

 * @proto: network protocol ID

 * @vid: vlan id being added

 */

static int bond_vlan_rx_add_vid(struct net_device *bond_dev,
@@ -355,6 +356,7 @@ static int bond_vlan_rx_add_vid(struct net_device *bond_dev, 
/**

 * bond_vlan_rx_kill_vid - Propagates deleting an id to slaves

 * @bond_dev: bonding net device that got called

 * @proto: network protocol ID

 * @vid: vlan id being removed

 */

static int bond_vlan_rx_kill_vid(struct net_device *bond_dev,
@@ -948,7 +950,7 @@ static bool bond_should_notify_peers(struct bonding *bond) 
/**

 * change_active_interface - change the active slave into the specified one

 * @bond: our bonding struct

 * @new: the new slave to make the active one

 * @new_active: the new slave to make the active one

 *

 * Set the new slave to the bond's settings and unset them on the old

 * curr_active_slave.