Commit 1f54391b authored by Pali Rohár's avatar Pali Rohár Committed by Lorenzo Pieralisi
Browse files

PCI: aardvark: Assert PERST# when unbinding driver 

Put the PCIe card into reset by asserting PERST# signal when unbinding
driver. It doesn't make sense to leave the card working if it can't
communicate with the host. This should also save some power.

Link: https://lore.kernel.org/r/20211130172913.9727-10-kabel@kernel.org


Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarMarek Behún <kabel@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
parent 2f040a17

drivers/pci/controller/pci-aardvark.c

+4 −0
Original line number Diff line number Diff line
@@ -1737,6 +1737,10 @@ static int advk_pcie_remove(struct platform_device *pdev) 
	/* Free config space for emulated root bridge */

	pci_bridge_emul_cleanup(&pcie->bridge);



	/* Assert PERST# signal which prepares PCIe card for power down */

	if (pcie->reset_gpio)

		gpiod_set_value_cansleep(pcie->reset_gpio, 1);



	/* Disable outbound address windows mapping */

	for (i = 0; i < OB_WIN_COUNT; i++)

		advk_pcie_disable_ob_win(pcie, i);