Unverified Commit 1e108e60 authored by Rob Herring's avatar Rob Herring Committed by Mark Brown
Browse files

ASoC: Use of_property_present() for testing DT property presence 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144732.1546328-1-robh@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 75034eb5

sound/soc/codecs/lpass-macro-common.c

+1 −1
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ struct lpass_macro *lpass_macro_pds_init(struct device *dev) 
	struct lpass_macro *l_pds;

	int ret;



	if (!of_find_property(dev->of_node, "power-domains", NULL))

	if (!of_property_present(dev->of_node, "power-domains"))

		return NULL;



	l_pds = devm_kzalloc(dev, sizeof(*l_pds), GFP_KERNEL);

sound/soc/generic/audio-graph-card.c

+1 −1
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ static int graph_get_dai_id(struct device_node *ep) 
		 * only of_graph_parse_endpoint().

		 * We need to check "reg" property

		 */

		if (of_get_property(ep,   "reg", NULL))

		if (of_property_present(ep,   "reg"))

			return info.id;



		node = of_get_parent(ep);

sound/soc/generic/audio-graph-card2.c

+1 −1
Original line number Diff line number Diff line
@@ -376,7 +376,7 @@ static int graph_get_dai_id(struct device_node *ep) 
		 * only of_graph_parse_endpoint().

		 * We need to check "reg" property

		 */

		if (of_get_property(ep,   "reg", NULL))

		if (of_property_present(ep,   "reg"))

			return info.id;



		node = of_get_parent(ep);

sound/soc/mxs/mxs-sgtl5000.c

+1 −1
Original line number Diff line number Diff line
@@ -150,7 +150,7 @@ static int mxs_sgtl5000_probe(struct platform_device *pdev) 


	card->dev = &pdev->dev;



	if (of_find_property(np, "audio-routing", NULL)) {

	if (of_property_present(np, "audio-routing")) {

		card->dapm_widgets = mxs_sgtl5000_dapm_widgets;

		card->num_dapm_widgets = ARRAY_SIZE(mxs_sgtl5000_dapm_widgets);

sound/soc/samsung/i2s.c

+1 −1
Original line number Diff line number Diff line
@@ -1289,7 +1289,7 @@ static int i2s_register_clock_provider(struct samsung_i2s_priv *priv) 
	int ret, i;



	/* Register the clock provider only if it's expected in the DTB */

	if (!of_find_property(dev->of_node, "#clock-cells", NULL))

	if (!of_property_present(dev->of_node, "#clock-cells"))

		return 0;



	/* Get the RCLKSRC mux clock parent clock names */