Commit 189cb8fe authored by John Garry's avatar John Garry Committed by Joerg Roedel
Browse files

iova: Remove iovad->rcaches check in iova_rcache_get() 



The iovad->rcaches check in iova_rcache_get() is pretty much useless
without the same check in iova_rcache_insert().

Instead of adding this symmetric check to fastpath iova_rcache_insert(),
drop the check in iova_rcache_get() in favour of making the IOVA domain
rcache init more robust to failure in future.

Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Reviewed-by: default avatarRobin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/1662557681-145906-4-git-send-email-john.garry@huawei.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 8b2818c7

drivers/iommu/iova.c

+1 −1
Original line number Diff line number Diff line
@@ -875,7 +875,7 @@ static unsigned long iova_rcache_get(struct iova_domain *iovad, 
{

	unsigned int log_size = order_base_2(size);



	if (log_size >= IOVA_RANGE_CACHE_MAX_SIZE || !iovad->rcaches)

	if (log_size >= IOVA_RANGE_CACHE_MAX_SIZE)

		return 0;



	return __iova_rcache_get(&iovad->rcaches[log_size], limit_pfn - size);