Commit 8b2818c7 authored by John Garry's avatar John Garry Committed by Joerg Roedel
Browse files

iova: Remove magazine BUG_ON() checks 



Two of the magazine helpers have BUG_ON() checks, as follows:
- iova_magazine_pop() - here we ensure that the mag is not empty. However
  we already ensure that in the only caller, __iova_rcache_get().
- iova_magazine_push() - here we ensure that the mag is not full. However
  we already ensure that in the only caller, __iova_rcache_insert().

As described, the two bug checks are pointless so drop them.

Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Acked-by: default avatarRobin Murphy <robin.murphy@arm.com>
Reviewed-by: default avatarJerry Snitselaar <jsnitsel@redhat.com>
Link: https://lore.kernel.org/r/1662557681-145906-3-git-send-email-john.garry@huawei.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent a390bde7

drivers/iommu/iova.c

+0 −4
Original line number Diff line number Diff line
@@ -694,8 +694,6 @@ static unsigned long iova_magazine_pop(struct iova_magazine *mag, 
	int i;

	unsigned long pfn;



	BUG_ON(iova_magazine_empty(mag));



	/* Only fall back to the rbtree if we have no suitable pfns at all */

	for (i = mag->size - 1; mag->pfns[i] > limit_pfn; i--)

		if (i == 0)
@@ -710,8 +708,6 @@ static unsigned long iova_magazine_pop(struct iova_magazine *mag, 


static void iova_magazine_push(struct iova_magazine *mag, unsigned long pfn)

{

	BUG_ON(iova_magazine_full(mag));



	mag->pfns[mag->size++] = pfn;

}