Commit 17e336db authored by Anupama K Patil's avatar Anupama K Patil Committed by Greg Kroah-Hartman
Browse files

drivers: pnp: proc.c: Removed unnecessary varibles 



de, e are two variables of the type 'struct proc_dir_entry'
which can be removed to save memory. This also fixes a coding style
issue reported by checkpatch where we are suggested to make assignment
outside the if statement.

Reviewed-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarAnupama K Patil <anupamakpatil123@gmail.com>
Link: https://lore.kernel.org/r/20210422180322.7wlyg63kv3n2k6id@ubuntu


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ca263dd8

drivers/pnp/isapnp/proc.c

+6 −7
Original line number Diff line number Diff line
@@ -57,21 +57,20 @@ static const struct proc_ops isapnp_proc_bus_proc_ops = { 
static int isapnp_proc_attach_device(struct pnp_dev *dev)

{

	struct pnp_card *bus = dev->card;

	struct proc_dir_entry *de, *e;

	char name[16];



	if (!(de = bus->procdir)) {

	if (!bus->procdir) {

		sprintf(name, "%02x", bus->number);

		de = bus->procdir = proc_mkdir(name, isapnp_proc_bus_dir);

		if (!de)

		bus->procdir = proc_mkdir(name, isapnp_proc_bus_dir);

		if (!bus->procdir)

			return -ENOMEM;

	}

	sprintf(name, "%02x", dev->number);

	e = dev->procent = proc_create_data(name, S_IFREG | S_IRUGO, de,

	dev->procent = proc_create_data(name, S_IFREG | S_IRUGO, bus->procdir,

					    &isapnp_proc_bus_proc_ops, dev);

	if (!e)

	if (!dev->procent)

		return -ENOMEM;

	proc_set_size(e, 256);

	proc_set_size(dev->procent, 256);

	return 0;

}