Commit 17b8d847 authored by Xiongfeng Wang's avatar Xiongfeng Wang Committed by Peter Zijlstra
Browse files

perf/x86/intel/uncore: Fix reference count leak in __uncore_imc_init_box() 



pci_get_device() will increase the reference count for the returned
pci_dev, so tgl_uncore_get_mc_dev() will return a pci_dev with its
reference count increased. We need to call pci_dev_put() to decrease the
reference count before exiting from __uncore_imc_init_box(). Add
pci_dev_put() for both normal and error path.

Fixes: fdb64822 ("perf/x86: Add Intel Tiger Lake uncore support")
Signed-off-by: default avatarXiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarKan Liang <kan.liang@linux.intel.com>
Link: https://lore.kernel.org/r/20221118063137.121512-5-wangxiongfeng2@huawei.com
parent 8ebd16c1

arch/x86/events/intel/uncore_snb.c

+3 −0
Original line number Diff line number Diff line
@@ -1338,6 +1338,7 @@ static void __uncore_imc_init_box(struct intel_uncore_box *box, 
	/* MCHBAR is disabled */

	if (!(mch_bar & BIT(0))) {

		pr_warn("perf uncore: MCHBAR is disabled. Failed to map IMC free-running counters.\n");

		pci_dev_put(pdev);

		return;

	}

	mch_bar &= ~BIT(0);
@@ -1352,6 +1353,8 @@ static void __uncore_imc_init_box(struct intel_uncore_box *box, 
	box->io_addr = ioremap(addr, type->mmio_map_size);

	if (!box->io_addr)

		pr_warn("perf uncore: Failed to ioremap for %s.\n", type->name);



	pci_dev_put(pdev);

}



static void tgl_uncore_imc_freerunning_init_box(struct intel_uncore_box *box)