Commit 8ebd16c1 authored by Xiongfeng Wang's avatar Xiongfeng Wang Committed by Peter Zijlstra
Browse files

perf/x86/intel/uncore: Fix reference count leak in snr_uncore_mmio_map() 



pci_get_device() will increase the reference count for the returned
pci_dev, so snr_uncore_get_mc_dev() will return a pci_dev with its
reference count increased. We need to call pci_dev_put() to decrease the
reference count. Let's add the missing pci_dev_put().

Fixes: ee49532b ("perf/x86/intel/uncore: Add IMC uncore support for Snow Ridge")
Signed-off-by: default avatarXiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarKan Liang <kan.liang@linux.intel.com>
Link: https://lore.kernel.org/r/20221118063137.121512-4-wangxiongfeng2@huawei.com
parent 1ff9dd6e

arch/x86/events/intel/uncore_snbep.c

+2 −0
Original line number Diff line number Diff line
@@ -5111,6 +5111,8 @@ static int snr_uncore_mmio_map(struct intel_uncore_box *box, 


	addr += box_ctl;



	pci_dev_put(pdev);



	box->io_addr = ioremap(addr, type->mmio_map_size);

	if (!box->io_addr) {

		pr_warn("perf uncore: Failed to ioremap for %s.\n", type->name);