Commit 16f1f838 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

Revert "ALSA: usb-audio: Drop superfluous interface setup at parsing" 



This reverts commit ac5e2fb4.

The commit caused a regression on Behringer UMC404HD (and likely
others).  As the change was meant only as a minor optimization, it's
better to revert it to address the regression.

Reported-and-tested-by: default avatarMichael Ralston <michael@ralston.id.au>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/CAC2975JXkS1A5Tj9b02G_sy25ZWN-ys+tc9wmkoS=qPgKCogSg@mail.gmail.com
Link: https://lore.kernel.org/r/20230104150944.24918-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 37b3e56d

sound/usb/stream.c

+6 −0
Original line number Diff line number Diff line
@@ -1222,6 +1222,12 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip, 
			if (err < 0)

				return err;

		}



		/* try to set the interface... */

		usb_set_interface(chip->dev, iface_no, 0);

		snd_usb_init_pitch(chip, fp);

		snd_usb_init_sample_rate(chip, fp, fp->rate_max);

		usb_set_interface(chip->dev, iface_no, altno);

	}

	return 0;

}