Commit ac5e2fb4 authored Aug 31, 2022 by Takashi Iwai

ALSA: usb-audio: Drop superfluous interface setup at parsing

We reset each interface that is being parsed for each stream, but this
is superfluous and even can lead to spurious errors.  Since the
interface is set up properly at opening the endpoint for each actual
stream operation, let's drop the superfluous one.

Link: https://lore.kernel.org/r/20220831130021.4762-1-tiwai@suse.de


Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 999b95a7

sound/usb/stream.c

+0 −6

Original line number	Original line	Diff line number	Diff line
	@@ -1221,12 +1221,6 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip,
	if (err < 0)		if (err < 0)
	return err;		return err;
	}		}

	/* try to set the interface... */
	usb_set_interface(chip->dev, iface_no, 0);
	snd_usb_init_pitch(chip, fp);
	snd_usb_init_sample_rate(chip, fp, fp->rate_max);
	usb_set_interface(chip->dev, iface_no, altno);
	}		}
	return 0;		return 0;
	}		}