Commit 162b937a authored by Shyam Sundar S K's avatar Shyam Sundar S K Committed by Hans de Goede
Browse files

platform/x86: amd-pmc: call dump registers only once 



Currently amd_pmc_dump_registers() routine is being called at
multiple places. The best to call it is after command submission
to SMU.

Signed-off-by: default avatarShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210629084803.248498-4-Shyam-sundar.S-k@amd.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 4c06d35d

drivers/platform/x86/amd-pmc.c

+1 −4
Original line number Diff line number Diff line
@@ -182,6 +182,7 @@ static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, bool set) 


out_unlock:

	mutex_unlock(&dev->lock);

	amd_pmc_dump_registers(dev);

	return rc;

}
@@ -194,7 +195,6 @@ static int __maybe_unused amd_pmc_suspend(struct device *dev) 
	if (rc)

		dev_err(pdev->dev, "suspend failed\n");



	amd_pmc_dump_registers(pdev);

	return 0;

}
@@ -207,7 +207,6 @@ static int __maybe_unused amd_pmc_resume(struct device *dev) 
	if (rc)

		dev_err(pdev->dev, "resume failed\n");



	amd_pmc_dump_registers(pdev);

	return 0;

}
@@ -279,8 +278,6 @@ static int amd_pmc_probe(struct platform_device *pdev) 
	if (!dev->regbase)

		return -ENOMEM;



	amd_pmc_dump_registers(dev);



	mutex_init(&dev->lock);

	platform_set_drvdata(pdev, dev);

	amd_pmc_dbgfs_register(dev);